Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature capkk controller #2419

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Feature capkk controller #2419

merged 9 commits into from
Oct 29, 2024

Conversation

dbbDylan
Copy link

@dbbDylan dbbDylan commented Sep 29, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/kind design

What this PR does / why we need it:

  • Complete CAPKK CRDs Controller
  • Complete basic controller functions: create and delete cluster
  • Add scope package and some other useful files here

Does this PR introduced a user-facing change?

- Complete CAPKK CRDs Controller
- Complete basic controller functions: create and delete cluster
- Add scope package and some other useful files here

Additional documentation, usage docs, etc.:

@kubesphere-prow Kubesphere Prow
Copy link

This PR has multiple commits, and the default merge method is: squash.
You can request commits to be merged using the label: tide/merge-method-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubesphere-prow kubesphere-prow bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed kind/design Categorizes issue or PR as related to design. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2024
@dbbDylan dbbDylan force-pushed the feature-capkk-controller branch from 6d0150d to d7ae6c2 Compare October 10, 2024 06:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@redscholar redscholar added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 29, 2024
@kubesphere-prow Kubesphere Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dbbDylan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit a083447 into kubesphere:feature-gitops Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbbDylan @ks-ci-bot @redscholar